Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "fix: update OOO e2e tests to remove flakiness" #18411

Merged
merged 1 commit into from
Dec 29, 2024
Merged

revert: "fix: update OOO e2e tests to remove flakiness" #18411

merged 1 commit into from
Dec 29, 2024

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Dec 29, 2024 •
edited
Loading

This PR #18367 has caused more flakes and e2e test failures in recent PRs. We always try to avoid time dependency in e2e tests. I will create a PR to fix the flakiness in OOO e2e tests.

@graphite-app graphite-app bot requested a review from a team December 29, 2024 14:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Revert "fix: update OOO e2e tests to remove flakiness"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Dec 29, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Dec 29, 2024
@anikdhabal anikdhabal changed the title Revert "fix: update OOO e2e tests to remove flakiness" revert: "fix: update OOO e2e tests to remove flakiness" Dec 29, 2024
@anikdhabal anikdhabal enabled auto-merge (squash) December 29, 2024 14:54
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 29, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal merged commit 0a29330 into main Dec 29, 2024
56 of 82 checks passed
@anikdhabal anikdhabal deleted the revert-18367-fix_flaky_OOO_tests branch December 29, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@vijayraghav-io
Copy link
Contributor

This PR #18367 has caused more flakes and e2e test failures in recent PRs. We always try to avoid time dependency in e2e tests. I will create a PR to fix the flakiness in OOO e2e tests.

I have checked locally as well as monitoring every PR (open and closed) with E2E lable, after this PR #18367 was merged, this has NOT caused more flakes but has reduced the flakes in OOO E2E tests.

Anyway Created new PR without time dependency - #18412

joeauyeung pushed a commit that referenced this pull request Jan 5, 2025
@anikdhabal @joeauyeung
Revert "update OOO e2e tests to remove flakiness (#18367)" (#18411)
200edc8 
This reverts commit e6ef4e1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh approved these changes

Assignees
No one assigned
Labels
automated-tests area: unit tests, e2e tests, playwright core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anikdhabal @vijayraghav-io @Praashh @keithwillcode